gui/macOS: Avoid crash from bad manager release
authorClaudio Cambra <claudio.cambra@nextcloud.com>
Wed, 26 Mar 2025 16:53:42 +0000 (17:53 +0100)
committerbackportbot[bot] <backportbot[bot]@users.noreply.github.com>
Thu, 27 Mar 2025 14:16:05 +0000 (14:16 +0000)
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
src/gui/macOS/fileprovideritemmetadata_mac.mm

index 8ff39979f9113eeaf992a7e505d91e28b5346cce..9a4e00c89be40369c1529d61e5df12bb003e8d4b 100644 (file)
@@ -122,7 +122,7 @@ QString FileProviderItemMetadata::getUserVisiblePath() const
     __block QString returnPath = QObject::tr("Unknown");
     NSFileProviderManager *const manager = FileProviderUtils::managerForDomainIdentifier(domainId);
 
-     if (manager == nil) {
+    if (manager == nil) {
         qCWarning(lcMacImplFileProviderItemMetadata) << "Null manager, cannot get item path";
         return returnPath;
     }
@@ -147,8 +147,6 @@ QString FileProviderItemMetadata::getUserVisiblePath() const
     dispatch_semaphore_wait(semaphore, DISPATCH_TIME_FOREVER);
     dispatch_release(semaphore);
 
-    [manager release];
-
     return returnPath;
 }